fix(style/--side-nav__navigation
): remove css height
to allow components at bottom (#5871)
#12152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--side-nav__navigation
): remove css height to allow components at bottom (UI shell left nav: Provide a mechanism to expand width panel + section for additional links #5871)This removes the CSS height style from
--side-nav__navigation
. The resulting style for this element when composed with--side-nav
is:With fixed positioning and top and bottom specified, the CSS
height
is unnecessary.Additionally, the CSS
height: 100%
calculates the height from the body, which is more than the viewport height. Thus, the height of the element will extend beyond the viewport, 'below the fold".The element
--side-nav__items
, included as a child element, hasflex-grow
set to1
, causing it to fill the entire height.Any element included after the side nav items in the side nav are pushed to the bottom. They should be expected to show entirely within the viewport, yet since the bottom is below, they either are not shown or are chopped off.
This fixes this issue.
Note: This may or may not solve #5871. It is not intended as a full solution, but it does fix this styling issue which would prevent properly supporting such a feature.
Changelog
Removed
--side-nav__navigation
: height removedTesting / Reviewing