fix(text-input): add class for inline validation #12231
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Had a few questions:
|
|
@tw15egan oh yes i updated the class but not in the css. The wrapping is due to the width in the story being at 300. But if you go to the "playgroundWidth" control in there you can make that larger and it fits well. I think it inline being is a difficult for invalid and warn texts since it's such a small area. People will need to keep it short and sweet. |
jnm2377
requested review from
a team and
thyhmdo
and removed request for
a team
|
Small ask @aledavila but can we change that text from "Invalid text" to "Error message goes here"? I think we'll try to be more consistent with our guidance languages and since we have this issue open so I just wanted to add that. |
|
@thyhmdo yup I'll change that no problem |
|
@thyhmdo updated now |
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Closes #10234
Fix validation on inline variant
Changelog
New
Testing / Reviewing
Make sure validation props still work. Make sure validation props inline are showing.