fix(UIShell): reduce padding on header name to fix action button (#11687) #12245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-design-system#11687) UIShell: SideNav Rail w/header - reduce padding to fix width of action button by: Animesh Samaiya (asamaiya00@gmail.com)
|
DCO Assistant Lite bot All contributors have signed the DCO. |
…sm-breakpoint-#11687
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
UIShell: SideNav Rail w/header - reduce padding to fix width of action button
by: Animesh Samaiya (asamaiya00@gmail.com)
…nt-#11687' of https://github.com/asamaiya00/carbon into bug/UI-Shell-menu-button-became-squashed-on-sm-breakpoint-#11687
|
@asamaiya00 looks good, can you sign the DCO by commenting the following: I have read the DCO document and I hereby sign the DCO. |
tw15egan
approved these changes
Oct 6, 2022
|
I have read the DCO document and I hereby sign the DCO. |
aledavila
approved these changes
Oct 6, 2022
…sm-breakpoint-#11687
…sm-breakpoint-#11687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIShell: SideNav Rail w/header - reduce padding on header name to fix the width of menu action button
by: Animesh Samaiya (asamaiya00@gmail.com)
Closes #11687
Menu button was becoming squashed somewhere between sm breakpoint (320px) and md breakpoint (672px). Fixed it by removing extra padding when md breakpoint is active. Also set the minimum width of the menu button, so that it doesn't squash further.
Changelog
Changed
packages/styles/scss/components/ui-shell/header/_header.scss
Testing / Reviewing
Current:
Changed:
Please review and let me know of any changes.
@tw15egan