Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overflowmenuitem): show title tooltip when disabled #12259

Merged

Conversation

tay1orjones
Copy link
Member

Closes #12257

Changelog

Changed

  • remove pointer-events: none, replace with cursor: not-allowed
  • update story to include an example using disabled and requireTitle

Testing / Reviewing

  1. Open the OverflowMenu/Default story
  2. hover over the disabled option
  3. the title text should appear on hover
title.text.appears.mov

@tay1orjones tay1orjones requested a review from a team as a code owner October 7, 2022 13:59
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 357ca07
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/635046077e36b6000838acba
😎 Deploy Preview https://deploy-preview-12259--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 357ca07
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63504607df459a000dfc758c
😎 Deploy Preview https://deploy-preview-12259--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tay1orjones tay1orjones requested review from jnm2377 and removed request for abbeyhrt October 12, 2022 20:25
@kodiakhq kodiakhq bot merged commit 68beab2 into carbon-design-system:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: OverflowMenuItem title text not shown when disabled
3 participants