Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ModalWrapper): deprecate for ComposedModal #12263

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Oct 7, 2022

Closes #12118

Changelog

  • adds deprecated section to storybook
  • adds deprecation warning to modal wrapper
  • adds migration doc for modal wrapper

Testing / Reviewing

  • ensure
    • all tests pass
    • modal wrapper is in the deprecated section
    • migration doc makes sense

@jnm2377 jnm2377 requested a review from aledavila October 7, 2022 22:14
@jnm2377 jnm2377 requested a review from a team as a code owner October 7, 2022 22:14
@jnm2377 jnm2377 requested a review from abbeyhrt October 7, 2022 22:14
@jnm2377 jnm2377 changed the title Deprecate modal wrapper chore(ModalWrapper): deprecate for ComposedModal Oct 7, 2022
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 813a001
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6345f75f07bf4000084bb88c
😎 Deploy Preview https://deploy-preview-12263--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 813a001
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6345f75f8bf4c9000945b746
😎 Deploy Preview https://deploy-preview-12263--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggested change but otherwise looks good!

Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 450ef8c into carbon-design-system:main Oct 11, 2022
@carbon-bot
Copy link
Contributor

Hey there! v11.15.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ModalWrapper deprecation
4 participants