Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inline-loading): storybook controls #12283

Merged

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Oct 11, 2022

Closes #12255

Added controls to a newly created Playground story.

Changelog

New

  • Created a Playground story with all the Controls.

Changed

  • Moved the defaultProps to default params. Updated the public API snapshot.
  • Updated the MDX to include the default story.

Testing / Reviewing

Ensure the InlineLoading stories all behave as expected.

@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 38f2031
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/634d95e8a429660008232dd4
😎 Deploy Preview https://deploy-preview-12283--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 38f2031
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/634d95e8cb8d110009133910
😎 Deploy Preview https://deploy-preview-12283--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 56921b1 into carbon-design-system:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Storybook controls: ensure InlineLoading has working controls/playground
3 participants