Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contained-list): remove unnecessary storybook controls #12346

Merged

Conversation

janhassel
Copy link
Member

Contributes to #12319

Removes actions, children and className from storybook controls table in "Playground" story.

Changelog

Changed

  • Updated control: false to table: { disable: true } to remove control entirely

Testing / Reviewing

  • Verify these three props are no longer shown in the controls table in the "Playground" story

@janhassel janhassel requested a review from a team as a code owner October 20, 2022 11:47
@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 942088c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6352be4d40953b000acb4c6a
😎 Deploy Preview https://deploy-preview-12346--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 942088c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6352be4dd0c6180008c6f83f
😎 Deploy Preview https://deploy-preview-12346--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 66caf2b into carbon-design-system:main Oct 21, 2022
@janhassel janhassel deleted the 12319-storybook-controls branch October 24, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants