Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UIShell): currentPage styles for sub-menu-item #12385

Merged

Conversation

ariellalgilmore
Copy link
Member

Closes #

#10132

Changelog

New

  • added additional styles for sub-menu-items in UIShell to have a border-left if it's the current page

Testing / Reviewing

Screen Shot 2022-10-25 at 9 05 26 AM

Screen Shot 2022-10-25 at 9 05 33 AM

wasn't sure if I should update the storybook, but screenshots above showing the sub-menu-items with the updated styles

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bcb2b89
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6359526e1c84c50008487b8b
😎 Deploy Preview https://deploy-preview-12385--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bcb2b89
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6359526e49a5980009212e04
😎 Deploy Preview https://deploy-preview-12385--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 41e692d into carbon-design-system:main Oct 26, 2022
@ariellalgilmore ariellalgilmore deleted the fix/UI-shell-current-styles branch October 26, 2022 17:35
@carbon-bot
Copy link
Contributor

Hey there! v11.16.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants