feat: readonly toggle #12402
Merged
feat: readonly toggle #12402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quarryboy current implementation assumes 1px offset of readonly switch 'md' size was a mistake and commission of check mark at small sizes an oversight. Both are easy to fix. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
approved these changes
Nov 1, 2022
| // ---------------------------------------- | ||
| // readonly | ||
| // ---------------------------------------- | ||
| // should this be a token of it's own? |
There was a problem hiding this comment.
I believe we've determined we won't be making tokens for these
Suggested change
| // should this be a token of it's own? |
alisonjoseph
approved these changes
Nov 8, 2022
tw15egan
requested review from
a team and
laurenmrice
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2177
Closes #12407
Adds the read-only feature to the Toggle component
Changelog
Added
Testing / Reviewing
Reviewed the result in Storybook and a added read-only test.