feat: add readonly functionality to select #12405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@quarryboy it was pointed out by @sstrubberg that we have no design for select. Can you rectify this? |
aagonzales
requested changes
Nov 1, 2022
|
@aagonzales cursor updated as requested. Did consider using 'text' cursor following last week's review, however, it does not appear possible to make text in a |
lee-chase
requested review from
aagonzales
and removed request for
tay1orjones and
aledavila
aagonzales
approved these changes
Nov 11, 2022
alisonjoseph
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2177
Closes #12423
Adds the read-only feature to the Select component
Changelog
Added
Testing / Reviewing
Reviewed the result in Storybook and a added read-only test.
Unfortunately, a way could not be found to test read-only preventing the selection of a value;