Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(StructuredList): add new RTL tests #12691

Merged

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Nov 17, 2022

Closes #12663

Removes the old enzyme tests for the StructuredList components, replaced with react testing library.

Changelog

Changed

  • StructuredList-test.js

Testing / Reviewing

Ran tests locally and all passed.
image

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7570cfa
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6375855ad90e7b0008c5dcb0
😎 Deploy Preview https://deploy-preview-12691--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7570cfa
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6375855ab7b187000988b905
😎 Deploy Preview https://deploy-preview-12691--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 16db42b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6375858430f35100082e0ac2
😎 Deploy Preview https://deploy-preview-12691--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 16db42b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6375858410d16b0009a42f59
😎 Deploy Preview https://deploy-preview-12691--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for helping out on this effort 💪🏻 🎉 ✅

@kodiakhq kodiakhq bot merged commit 30fd7ea into carbon-design-system:main Nov 28, 2022
@matthewgallo matthewgallo deleted the 12663-structured-list-rtl branch November 28, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in StructuredList-test.js
4 participants