Add typescript types to combo box

[sierrawetmore]

Closes #12538

This PR converts ComboBox.js to typescript.

Changelog

Changed

• ComboBox.js has been converted to TS

Testing / Reviewing

These changes can be tested and verified by running a fresh yarn, yarn build and yarn storybook. Verify that the behavior in the ComboBox story remains unchanged

[github-actions]

DCO Assistant Lite bot All contributors have signed the DCO.

[netlify]

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	b15f51e
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/63e533cb8c9ffa0008428e4b
😎 Deploy Preview	https://deploy-preview-12873--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	b15f51e
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/63e533cb85748e00077a5803
😎 Deploy Preview	https://deploy-preview-12873--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[sierrawetmore]

I have read the DCO document and I hereby sign the DCO.

[sierrawetmore]

recheck

[tay1orjones]

Hey, thanks for contributing this! One minor ask - instead of renaming the .js file to .tsx, could you actually rename it using git?

git mv packages/react/src/components/ComboBox/ComboBox.js packages/react/src/components/ComboBox/ComboBox.tsx

This way the diff will clearly show the file extension change but also the proper unified diff showing your changes within file.

Right now it's hard to tell what you've added to the file vs was was in it to begin with.

Also we should wait to merge this until #12787 is in

[tay1orjones]

Here’s an example of how the diff should look after renaming via git mv alongside changes within the file

[sierrawetmore]

Thanks, didn't realize that was the better way of renaming it. It should look better now!

[tay1orjones]

@sierrawetmore Awesome yeah that looks great! #12787 is in - I think it caused some merge conflicts here

[aledavila]

Bump @sierrawetmore

[sierrawetmore]

This is on my to-do list in the next couple days. Also waiting to see where we land on the generic types conversation.

[tay1orjones]

The biggest blocker here I think is the props being destructured out of ...rest. Also a few questions below

[tw15egan]

Functionality hasn't changed, no failing tests / a11y violations. LGTM 👍🏻 ✅

[tay1orjones]

Thank you! 🏆