Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(TableToolbarMenu): update tests to RTL #13172

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Feb 16, 2023

Closes #12673

Updates TableToolbarMenu tests to RTL

Changelog

Screenshot 2023-02-16 at 10 15 38 AM

Changed

  • Updates and expands test coverage for TableToolbarMenu
  • Update snapshot

Testing / Reviewing

Ensure all tests pass and all props are covered by tests

yarn test packages/react/src/components/DataTable/__tests__/TableToolbarMenu-test.js

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d84e22
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63f7cc43eaf41c00081154ee
😎 Deploy Preview https://deploy-preview-13172--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ba70992
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63f791bf1982300008dc4fc4
😎 Deploy Preview https://deploy-preview-13172--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 5024767 into carbon-design-system:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in DataTable/__tests__/TableToolbarMenu-test.js
3 participants