fix(date-picker): stabilize defaultDate behavior #13186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore time in date objects when comparing for equality to prevent overrides * clear input values on rerender when value prop is set to prevent overrides * Add test story (to be deleted)
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Feb 21, 2023
francinelucca
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tw15egan
approved these changes
Feb 23, 2023
francinelucca
changed the title
francinelucca
added
status: enable automerge 🟠
and removed
status: one more review 👀
DO NOT MERGE
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13058
Why
Issue here was with the introduction of
hasInputthe calendar instance is being destroyed and recreated the first time the components loads; so when a default value is set and the calendar instance was destroyed after the inputs had been populated (with the default values), it was picking up the dates both from the input fields and thedefaultDatevalue, causing the flatpickr instance to behave unexpectedly.Upon fixing that, found another issue where attempting to change the date through the calendar when a defaultValue had been previously set required the user to double click on the date due to the first click being overriden by a date equality comparison that didn't evaluate to
truedue to digressing times on the date resulting from a date object being created from thedefaultValueVS creating it from the calendar selection.Changelog
Changed
Testing / Reviewing
Test using "test" story in Datepicker in deployment
TODO