test: convert TableHeader to RTL #13204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
andreancardona
changed the title
francinelucca
requested changes
Feb 21, 2023
packages/react/src/components/DataTable/__tests__/TableHeader-test.js
Outdated
Show resolved
Hide resolved
tay1orjones
approved these changes
Feb 22, 2023
francinelucca
requested changes
Feb 22, 2023
packages/react/src/components/DataTable/__tests__/TableHeader-test.js
Outdated
Show resolved
Hide resolved
…test.js Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
francinelucca
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12668
Changed
TableHeaderTesting / Reviewing
Ensure all tests pass and all props are covered by tests
yarn test packages/react/src/components/DataTable/__tests__/TableHeader-test.js