feat(theme): add $icon-interactive token #13219

tw15egan · 2023-02-23T17:18:33Z

Closes #13217

Adds a new $icon-interactive token

White and Gray 10 theme: Blue 60 #0f62fe

Gray 90 and Gray 100 theme: White #ffffff

Changelog

New

$icon-interactive added to all themes

Changed

Updated snapshots

Testing / Reviewing

Ensure token values are correct for each theme

netlify · 2023-02-23T17:23:09Z

✅ Deploy Preview for carbon-components-react ready!

Name	Link
🔨 Latest commit	`f62713a`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/63f79feb12ed7e00085d2677
😎 Deploy Preview	https://deploy-preview-13219--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-02-23T17:28:36Z

✅ Deploy Preview for carbon-components-react ready!

Name	Link
🔨 Latest commit	`5e093f0`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/6400d702d7c4e800080df2fb
😎 Deploy Preview	https://deploy-preview-13219--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/themes/src/tokens/v11TokenGroup.js

packages/themes/src/tokens/__tests__/metadata-test.js

packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap

Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>

….snap

tw15egan · 2023-02-23T19:31:54Z

@alisonjoseph should be fixed now, thanks for catching that 😅

alisonjoseph

🚀

tay1orjones · 2023-02-23T20:49:47Z

@tw15egan Any idea why the elements preview didn't deploy for this PR? I was going to check it but it's not listed 🤔

tw15egan · 2023-02-23T20:51:52Z

@tay1orjones I just checked a few other PR's and I'm not seeing it on any of them ... 😬

netlify · 2023-03-01T14:02:27Z

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	`5e093f0`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/6400d702163f0a0008c21afe
😎 Deploy Preview	https://deploy-preview-13219--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tw15egan · 2023-03-01T14:04:35Z

@thyhmdo this should be ready for review now 👍🏻

thyhmdo

looks good. Thanks!

carbon-bot · 2023-03-03T15:17:17Z

Hey there! v11.24.0 was just released that references this issue/PR.

* refactor(Dropdown): ariaLabel to aria-label * fix(menu): fix arrow key navigation when onClose is called but not closed (#13195) * fix(menu): only clear registered items when root is closing * fix(menu): auto-cleanup registered items --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(theme): add $icon-interactive token (#13219) * feat(theme): add $icon-interactive token * Update packages/themes/src/tokens/v11TokenGroup.js Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> * Update packages/themes/src/tokens/__tests__/metadata-test.js Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> * Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap * Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap * chore(snapshot): update snapshots --------- Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> * feat(TextInput): add typescript types (#13142) * feat(TextInput): add typescript types * fix(Text Input): submcompnent workaround + add helperID prop * chore(format): format `Popover`, `Listbox` files (#13284) * chore(format): format Popover file * chore(format): format ListBox files * chore(format): update format command * chore(release): v11.24.0 (#13282) Co-authored-by: tay1orjones <tay1orjones@users.noreply.github.com> * fix(toggle): make props.labelText optional (#13196) * fix(toggle): make props.labelText optional * docs(toggle): add 'with accessible labels' story * test(toggle): update public api snapshot --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(ListBox): a11y - move filter tag as sibling of menu trigger, esc key improvements (#13173) * fix(MultiSelect): a11y - move filter tag as sibling of menu trigger * fix(Multiselect): remove tag from tab order * fix(FilterableMultiselect): remove clear, tag from tab order * fix(ComboBox): retain input value when menu is open and esc is pressed * fix(FilterableMultiSelect): a few more UX tweaks * style(MultiSelect): update styles to fix invalid issues when focused * style(FluidMultiselect): adjust focus styles when invalid * chore(log): remove console log --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> * docs(style): add section on authoring inline styles (#13289) * docs(style): add section on authoring inline styles * docs(style): rephrase inline style docs * docs(style): typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(ComboBox): ariaLabel to aria-label (#13273) * refactor(ComboBox): ariaLabel to aria-label * fix: formatting --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> * fix(tabs): remove max-width (#13247) * fix(tabs): remove max-width * docs(tabs): add max width guidance * docs(tabs): format --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(ListBox): Standardize `ListBox` menu open behavior (#13268) * style(MultiSelect): update styles to fix invalid issues when focused * style(FluidMultiselect): adjust focus styles when invalid * chore(log): remove console log * fix(ListBox): align open behaviors across ListBox components --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Add Typescript annotations to Select, SelectItem and SelectItemGroup (#13235) * refactor(typescript): type annotations on Select* Add Typescript annotations to Select, SelectItem and SelectItemGroup. * fix(lint): removed unused imports Left SelectItem and SelectItemGroup in the imports after using them for testing. Removed. * fix(Select-test): update label to labelText Previously removed label as it was not a property of Select. On recommendation of maintainers reintroduced using labelText. * Apply suggestions from code review Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> * Follow up to change suggestions --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(FilterableMultiSelect): ariaLabel to aria-label (#13276) Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com> * fix(SkeletonText): prevent negative px width values (#13270) Co-authored-by: Alessandra Davila <adavila91@gmail.com> * feat(Popover): add `isTabTip` prop to `Popover` (#13283) * feat(tabTipPopover): add tabTip to Popover * feat(tabTipPopover): add tab-tip styles, story * test(Popover): add e2e tests * style(Popover): adjust storybook styles * fix(Popover): add new prop to proptypes * chore(snapshot): update snapshots * docs(Popover): add close on esc to story * docs(Popover): fix typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(deps): bump minimist in /packages/react/examples/react-router (#13254) Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(StructuredList): ariaLabel to aria-label (#13261) * refactor(StructuredListWrapper): ariaLabel to aria-label * fix(StructuredList test): use 'aria-label' --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(DataTable): add rowIds to the sortRows extra params list (#13236) Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(typescript): add various typescript typings (#13234) * feat(TableToolbar): add typescript typings * feat(TableToolbarAction): add typescript typings * feat(TableToolbarContent): change to `tsx` * feat(TableToolbarMenu): add typescript typings * feat(OverflowMenuItem): add typescript typings * fix: format --------- Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: Francine Lucca <francinelucca@hotmail.com> * fix(RadioTile): forward ref to input node (#13130) Forward ref to input node of RadioTile, such that it behaves the same as other form inputs. Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> * feat: migration examples prefix selectors (#13264) * feat(ContentSwitcher): preliminary unstable refactor * feat: added prefix and id prefix examples * fix: delete content switcher directory * feat: update demos * Update examples/id-prefix/src/App.jsx Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> * Update packages/react/src/components/IdPrefix/index.js * feat: added docs * fix: update context * fix: yarn install * fix: update context 2 * chore: update yarn packages * chore: udpate yarn carbon/react --------- Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(DataTableSkeleton): 12513 - Add TS types for props (#13245) * feat(DataTableSkeleton): 12513 - Add TS types for props * fix: yarn run format --------- Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: Francine Lucca <francinelucca@hotmail.com> * test(datatable): refactor to use RTL (#13294) * chore: wip * chore: wip * test(datatable): refactor to use RTL * chore: typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(modal): aria-label a11y bug (#13242) Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * test(HeaderSideNavItems): add tests (#13303) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * docs(Storybook): update storybook config so actions display properly (#13302) * docs(Storybook): update storybook config so actions display properly * fix(DatePicker): change action names --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(tabs): deprecate light prop (#13262) Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(menu): focus first item when opened (#13277) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(CodeSnippet): a11y tabstop + attributes (#13310) * fix(CodeSnippet): a11y tabstop + attributes * fix(CSS): add Carbon CSS to focus outline * refactor(CodeSnippet): relocate parens * refactor(OverflowMenu): ariaLabel to aria-label (NEW) (#13280) * fix(CodeSnippet): a11y tabstop + attributes * fix(CSS): add Carbon CSS to focus outline * refactor(OverflowMenu): ariaLabel to aria-label NEW * Delete CodeSnippet.js error from a rebase/merge * Delete _code-snippet.scss error from rebase/merge * revert(missingFiles): they'll be ignored on merge --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(test): remove enzyme (#13316) * test(accordion): refactor from enzyme to RTL * chore(test): remove enzyme --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(CodeSnippet): ariaLabel to aria-label (#13274) Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> * feat(TextArea): add warning state (#13293) * feat(TextArea): add warning state * chore: update snapshots * fix: textarea error bottom border and default value in story * chore: hide resize fluid textarea invalid and warn --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor: convert TextAreaSkeleton to TypeScript (#13275) * refactor: convert TextAreaSkeleton to TypeScript * chore: remove unneeded omit * chore: remove unneeded omit --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(batchToolTips): make tooltips on batch visible (#13328) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(Notification): ariaLabel to aria-label (#13281) * refactor(Notification): ariaLabel to aria-label * fix(Notification): rm stories default dupes * fix(InlineNotification): rm deprecated prop --------- Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(format): tsx formatting --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jan Hassel <jan.hassel@ibm.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: Bianca Sparxs <33003148+bianca-sparxs@users.noreply.github.com> Co-authored-by: carbon-automation[bot] <103539138+carbon-automation[bot]@users.noreply.github.com> Co-authored-by: tay1orjones <tay1orjones@users.noreply.github.com> Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: jpsorensen <93107699+jpsorensen@users.noreply.github.com> Co-authored-by: andrew <emyarod@users.noreply.github.com> Co-authored-by: Alessandra Davila <adavila91@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Knabe <cknabe@us.ibm.com> Co-authored-by: GalvinGao <me@galvingao.com> Co-authored-by: Francine Lucca <francinelucca@hotmail.com> Co-authored-by: remolueoend <remolueoend@users.noreply.github.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com> Co-authored-by: Sierra Wetmore <107062203+sierrawetmore@users.noreply.github.com> Co-authored-by: Austin <aj_viens_deruisseau@yahoo.com>

tw15egan requested review from a team as code owners February 23, 2023 17:18

tw15egan requested review from alisonjoseph, francinelucca and thyhmdo February 23, 2023 17:18

tw15egan added status: ready for review 👀 status: visual review 🔍 labels Feb 23, 2023

alisonjoseph requested changes Feb 23, 2023

View reviewed changes

packages/themes/src/tokens/v11TokenGroup.js Outdated Show resolved Hide resolved

packages/themes/src/tokens/__tests__/metadata-test.js Outdated Show resolved Hide resolved

tw15egan commented Feb 23, 2023

View reviewed changes

packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap Outdated Show resolved Hide resolved

tw15egan commented Feb 23, 2023

View reviewed changes

packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap Outdated Show resolved Hide resolved

tw15egan and others added 6 commits February 23, 2023 14:23

feat(theme): add $icon-interactive token

cda8df7

Update packages/themes/src/tokens/v11TokenGroup.js

b901803

Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>

Update packages/themes/src/tokens/__tests__/metadata-test.js

51a2f06

Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>

Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js…

afc8c4e

….snap

Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js…

f6896d1

….snap

chore(snapshot): update snapshots

d2def3b

tw15egan force-pushed the add-icon-interactive branch from 416f5a6 to d2def3b Compare February 23, 2023 19:31

alisonjoseph approved these changes Feb 23, 2023

View reviewed changes

francinelucca approved these changes Feb 23, 2023

View reviewed changes

tay1orjones approved these changes Feb 23, 2023

View reviewed changes

tw15egan added 2 commits February 28, 2023 13:06

Merge branch 'main' into add-icon-interactive

a4570c6

Merge branch 'main' into add-icon-interactive

74fc807

thyhmdo approved these changes Mar 2, 2023

View reviewed changes

tw15egan added status: ready to merge 🎉 and removed status: ready for review 👀 status: visual review 🔍 labels Mar 2, 2023

Merge branch 'main' into add-icon-interactive

5e093f0

kodiakhq bot merged commit b32cee5 into carbon-design-system:main Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(theme): add $icon-interactive token #13219

feat(theme): add $icon-interactive token #13219

tw15egan commented Feb 23, 2023

netlify bot commented Feb 23, 2023

netlify bot commented Feb 23, 2023 •

edited

Loading

tw15egan commented Feb 23, 2023

alisonjoseph left a comment

tay1orjones commented Feb 23, 2023

tw15egan commented Feb 23, 2023

netlify bot commented Mar 1, 2023 •

edited

Loading

tw15egan commented Mar 1, 2023

thyhmdo left a comment

carbon-bot commented Mar 3, 2023

feat(theme): add $icon-interactive token #13219

feat(theme): add $icon-interactive token #13219

Conversation

tw15egan commented Feb 23, 2023

Changelog

Testing / Reviewing

netlify bot commented Feb 23, 2023

✅ Deploy Preview for carbon-components-react ready!

netlify bot commented Feb 23, 2023 • edited Loading

✅ Deploy Preview for carbon-components-react ready!

tw15egan commented Feb 23, 2023

alisonjoseph left a comment

Choose a reason for hiding this comment

tay1orjones commented Feb 23, 2023

tw15egan commented Feb 23, 2023

netlify bot commented Mar 1, 2023 • edited Loading

✅ Deploy Preview for carbon-elements ready!

tw15egan commented Mar 1, 2023

thyhmdo left a comment

Choose a reason for hiding this comment

carbon-bot commented Mar 3, 2023

netlify bot commented Feb 23, 2023 •

edited

Loading

netlify bot commented Mar 1, 2023 •

edited

Loading