Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css-grid): update packages #13241

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Feb 27, 2023

Closes #13226

Updates a few element packages preview apps to use next (moving away from parcel) and bumps the react version for these packages to 17.0.2.

Changelog

Changed

  • packages/grid/examples/css-grid: bumped next from v10 to v12
  • packages/grid/examples/preview: converted the app from parcel to next
  • packages/themes/examples/preview-v10: converted the app from parcel to next
  • packages/type/examples/preview: bumped next from v10 to v12

Testing / Reviewing

Ensure the elements preview looks like it did before it stopped working, especially the packages listed above.

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bf0f7fd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63fe4c0d020baa0008b334ea
😎 Deploy Preview https://deploy-preview-13241--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bf0f7fd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63fe4c0dd335f70008ef927c
😎 Deploy Preview https://deploy-preview-13241--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tw15egan tw15egan marked this pull request as ready for review February 27, 2023 20:03
@tw15egan tw15egan requested a review from a team as a code owner February 27, 2023 20:03
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kodiakhq kodiakhq bot merged commit 587d5a7 into carbon-design-system:main Feb 28, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.24.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elements previews are not working
4 participants