test(SideNavDivider): add tests #13313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
packages/react/src/components/UIShell/__tests__/SideNavDivider-test.js
Outdated
Show resolved
Hide resolved
andreancardona
approved these changes
Mar 9, 2023
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
aledavila
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
lgtm @francinelucca do we need to add the 2023 that andrea mentioned above ^
ShreyDhyani
approved these changes
Mar 16, 2023
francinelucca
added
status: enable automerge 🟠
and removed
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12858
Changelog
New
-packages/react/src/components/UIShell/tests/SideNavDivider-test.js: add test file for SideNavDivider
Testing / Reviewing
Should test every prop in
SideNavDividerand all tests should pass