Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add testing for Switcher, SwitcherDivider and SwitcherItem #13342

Conversation

francinelucca
Copy link
Collaborator

@francinelucca francinelucca commented Mar 13, 2023

Closes #12859

Adds testing for Switcher, SwitcherDivider and SwitcherItem.
Also refactors test generator script to generate IBM Copyright header using current year.

Changelog

New

  • packages/react/src/components/UIShell/tests/Switcher-test.js: add test file for Switcher
  • packages/react/src/components/UIShell/tests/SwitcherDivider-test.js: add test file for SwitcherDivider
  • packages/react/src/components/UIShell/tests/SwitcherItem-test.js: add. test file for SwitcherItem
  • packages/react/tasks/build-test-rtl.js: generate IBM copyright header based on current year

Testing / Reviewing

Should test every prop in Switcher, SwitcherItem and SwitcherDivider and all tests should pass

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit e8c7459
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64109f418635420008015afb
😎 Deploy Preview https://deploy-preview-13342--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e8c7459
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64109f41508e390008d2ee5b
😎 Deploy Preview https://deploy-preview-13342--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to update copyright header :)

@andreancardona andreancardona self-requested a review March 14, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for Switcher, SwitcherDivider, SwitcherItem
3 participants