fix(DatePicker): add override behavior for start date deletion bug #13443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Oooh I was gonna bug you to look at this next week, but you're too fast! 🔥 This works if I type in the date and click off, but if I click a date on the calendar and click off it disappears, or click back in/out if disappears too. wondering if that is also something we could/should fix? |
Ah I see what you mean... I/we can take a look next week! |
…980-bug-date-picker-of-type-range-never-call-onchange-when-second-input-value-change
Co-authored-by: Alison Joseph <alisonjoseph@users.noreply.github.com>
|
Ready for re-rev! @alisonjoseph @andreancardona |
francinelucca
added
status: one more review 👀
and removed
status: ready for review 👀
labels
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
…ll-onchange-when-second-input-value-change
…ll-onchange-when-second-input-value-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12980
Changelog
Changed
fixEventsPluginto programatically re-set the start date that is getting deleted on theendDateblur due to the flatpickr bugTesting / Reviewing
Follow reproduction steps in #12980 and confirm calendar gets updated in PR deployment. Also test DatePicker keyboard and mouse behavior to ensure no regressions