fix(ToggleSkeleton): fix issue with ToggleSkeleton style #13963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Mohammed Aslam P. A <Mohammed.Aslam.P.A@ibm.com>
modaslam
force-pushed
the
bugfix/toggleskeleton-broken-visual
branch
from
0be906a
to
ea52955
Compare
|
I have read the DCO document and I hereby sign the DCO. |
francinelucca
requested review from
a team and
kingtraceyj
and removed request for
a team
I have added a similar animation for the circle as well if you need to check and also resolved the merge conflicts. @francinelucca |
francinelucca
requested changes
Jun 14, 2023
francinelucca
approved these changes
Jun 14, 2023
kingtraceyj
approved these changes
Jun 16, 2023
francinelucca
added
status: one more review 👀
and removed
status: visual review 🔍
labels
andreancardona
approved these changes
Jun 19, 2023
francinelucca
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13459 and #13485
Fixed broken visuals of ToggleSkeleton component and added a story for it
Changelog
New
Changed
Removed
Testing / Reviewing
Go to the story in Toggle folder and ensure the Skeleton is displayed correctly according to design spec shown in #13485.