Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slider keyboard avt testing #14160

Merged
merged 48 commits into from
Jul 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
1bcb232
feat: contained list persistent search
andreancardona Mar 31, 2023
b4c59bd
Merge branch 'main' into contained-list-persistent-search-3
andreancardona Apr 4, 2023
2fe97f6
docs: update docs for contained list search
andreancardona Apr 7, 2023
b69b5bd
fix: fix border
andreancardona Apr 10, 2023
d09b917
feat: functionality working
andreancardona Apr 10, 2023
763283f
fix(tabs): hover style bugs
alisonjoseph Apr 10, 2023
665bed4
fix: remove hover from disabled state
alisonjoseph Apr 10, 2023
ce07f2a
feat: clean up code
andreancardona Apr 10, 2023
a224005
Update packages/react/src/components/ContainedList/ContainedList.mdx
andreancardona Apr 10, 2023
aa8947e
fix: update docs
andreancardona Apr 10, 2023
28b000c
Merge branch 'contained-list-persistent-search-3' of github.com:andre…
andreancardona Apr 10, 2023
a9f8b8b
fix: fix styling
andreancardona Apr 10, 2023
814cc3b
fix: update docs
andreancardona Apr 11, 2023
b45a5bf
Merge branch 'main' into contained-list-persistent-search-3
andreancardona Apr 11, 2023
0b8b9f9
Merge branch 'main' into contained-list-persistent-search-3
andreancardona Apr 12, 2023
f63a300
Merge branch 'main' into 13490-tab-hover-bug
andreancardona Apr 13, 2023
6757739
Merge branch 'main' into 13490-tab-hover-bug
kodiakhq[bot] Apr 18, 2023
231d315
Merge branch '13490-tab-hover-bug' of github.com:alisonjoseph/carbon;…
andreancardona Apr 18, 2023
d91e70d
Merge branch 'main' into contained-list-persistent-search-3
andreancardona Apr 18, 2023
b759ac5
fix: failing test
andreancardona Apr 18, 2023
b214fd6
Merge branch 'main' into contained-list-persistent-search-3
andreancardona Apr 18, 2023
686a43f
fix: fix tests
andreancardona Apr 19, 2023
cce6839
Merge branch 'andreancardona-contained-list-persistent-search-3'
andreancardona Apr 19, 2023
5e959a5
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona May 5, 2023
1a6d1c1
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona May 17, 2023
6607284
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona May 23, 2023
64172da
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona May 24, 2023
8fb6526
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona May 25, 2023
5abf03d
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona May 30, 2023
4841276
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jun 7, 2023
7863df0
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jun 16, 2023
2cc6688
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jun 19, 2023
619e7cf
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jun 22, 2023
fc7d694
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jun 27, 2023
4d031b7
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jun 28, 2023
2dce7b0
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jul 6, 2023
1bec76e
Merge branch 'main' of github.com:carbon-design-system/carbon
andreancardona Jul 7, 2023
ee3ff5d
feat: basic keyboard testing
andreancardona Jul 7, 2023
8251fe3
Merge branch 'main' into 14119-slider-keyboard
andreancardona Jul 7, 2023
ee52a03
Merge branch 'main' into 14119-slider-keyboard
andreancardona Jul 18, 2023
8211039
feat: slider keyboard nav
andreancardona Jul 19, 2023
8c18319
Merge branch 'main' into 14119-slider-keyboard
andreancardona Jul 19, 2023
2cb7a03
Merge branch '14119-slider-keyboard' of github.com:andreancardona/car…
andreancardona Jul 19, 2023
c9c59b6
feat: updated get by role
andreancardona Jul 19, 2023
c56c22d
Merge branch 'main' into 14119-slider-keyboard
andreancardona Jul 19, 2023
a7c7b8c
feat: update failing test
andreancardona Jul 19, 2023
0982b17
fix: trying to fix failing tests
andreancardona Jul 20, 2023
654a34a
fix: avt timeout
andreancardona Jul 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/components/OverflowMenu/OverflowMenu-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ test.describe('OverflowMenu', () => {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('OverflowMenu');
await expect(page).toHaveNoACViolations('OverflowMenu feature-flag');
});
});
97 changes: 97 additions & 0 deletions e2e/components/Slider/Slider-test.avt.e2e.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
/**
* Copyright IBM Corp. 2016, 2023
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

const { expect, test } = require('@playwright/test');
const { visitStory } = require('../../test-utils/storybook');

test.describe('Slider @avt', () => {
test('accessibility-checker @avt - Slider default state', async ({
page,
}) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--default',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('Slider');
});

test('accessibility-checker controlled slider', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--controlled-slider',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('Slider-controlled');
});

test('accessibility-checker controlled slider with layer', async ({
page,
}) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--controlled-slider-with-layer',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations(
'Slider-controlled-slider-with-layer'
);
});

test('accessibility-checker skeleton', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--skeleton',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('Slider-skeleton');
});

test('accessibility-checker slider with layer', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--with-layer',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('Slider-with-layer');
});

// Prevent timeout
test.slow('default state - keyboard nav', async ({ page }) => {
await visitStory(page, {
component: 'Slider',
id: 'components-slider--default',
globals: {
theme: 'white',
},
});

// Focus on the slider via keyboard navigation
await page.keyboard.press('Tab');
await expect(page.getByRole('slider')).toBeVisible();
await page.keyboard.press('Tab');
await expect(page.getByRole('slider')).toBeFocused();

await page.keyboard.press('Tab');
await expect(page.getByRole('spinbutton')).toBeFocused();

await page.keyboard.insertText('20');
await expect(page.getByRole('spinbutton')).toHaveValue('20');
});
});
17 changes: 2 additions & 15 deletions e2e/components/Slider/Slider-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

'use strict';

const { expect, test } = require('@playwright/test'); // eslint-disable-line
const { test } = require('@playwright/test'); // eslint-disable-line
const { themes } = require('../../test-utils/env');
const { snapshotStory, visitStory } = require('../../test-utils/storybook'); // eslint-disable-line
const { snapshotStory } = require('../../test-utils/storybook'); // eslint-disable-line

test.describe('Slider', () => {
themes.forEach((theme) => {
Expand All @@ -31,17 +31,4 @@ test.describe('Slider', () => {
});
});
});

// TODO: uncomment when https://github.com/IBMa/equal-access/issues/761 is resolved

// test('accessibility-checker @avt', async ({ page }) => {
// await visitStory(page, {
// component: 'Slider',
// id: 'components-slider--default',
// globals: {
// theme: 'white',
// },
// });
// await expect(page).toHaveNoACViolations('Slider');
// });
});
2 changes: 2 additions & 0 deletions packages/react/src/components/Slider/Slider.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const ControlledSlider = () => {
randomize value
</button>
<Slider
labelText="Slider label"
max={100}
min={0}
value={val}
Expand Down Expand Up @@ -82,6 +83,7 @@ export const ControlledSliderWithLayer = () => {
randomize value
</button>
<Slider
labelText="Slider label"
max={100}
min={0}
value={val}
Expand Down
Loading