Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): fix issue with text rendering in storybook props table #14207

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

tw15egan
Copy link
Member

Closes #14040

Fixes an issue with some weird visual bugs / text rendering in different sizes in the props table in storybook

Changelog

New

  • Added some storybook-specific styles to target these incorrect styles.

Testing / Reviewing

Open up the storybook and navigate to a props table, ensure all the text is the same size and that the props marked deprecated don't have a weird border around them

@tw15egan tw15egan requested a review from a team as a code owner July 13, 2023 15:28
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 17a5528
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64b018171c30e80007807639
😎 Deploy Preview https://deploy-preview-14207--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 17a5528
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64b0181775309e000879af46
😎 Deploy Preview https://deploy-preview-14207--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones added this pull request to the merge queue Jul 17, 2023
Merged via the queue into carbon-design-system:main with commit f2aa208 Jul 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook: Revise deprecated prop in Storybook
3 participants