fix(button): update imports to use the default export instead of named #14301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tay1orjones
added
severity: 2
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Jul 25, 2023
alisonjoseph
approved these changes
Jul 25, 2023
Merged
via the queue into
carbon-design-system:main
with commit Jul 25, 2023
9f26e64
20 checks passed
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in slack
A continuation of #14194, this fixes the Button, ComboButton, and MenuButton stories to no longer have the
Cannot access '__WEBPACK_DEFAULT_EXPORT__' before initializationerrorTo verify, view the stories and ensure no error. When on the default MenuButton story, refresh the page and ensure no error there as well. The issue was somewhat intermittent.