Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HeaderMenu): use composeEventHandlers in HeaderMenu #14353

Merged

Conversation

tw15egan
Copy link
Member

Refs #14311

Adds in composeEventHandlers so that user onClick, onBlur, and onKeyDown functions are respected

Changelog

Changed

  • Instead of only calling our event handlers, adds in the composeEventHandlers tool so that user events handlers are respected

Testing / Reviewing

Try passing an onClick with console.log to HeaderMenu. You should see your log

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit a2b01f7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c7e7f64cd80c0008058fef
😎 Deploy Preview https://deploy-preview-14353--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a2b01f7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c7e7f61c99020008a0113b
😎 Deploy Preview https://deploy-preview-14353--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Jul 31, 2023
Merged via the queue into carbon-design-system:main with commit a679dae Jul 31, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants