Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: onboard remaining packages to IBM Telemetry 🚀 #15844

Merged

Conversation

mattrosno
Copy link
Member

@mattrosno mattrosno commented Feb 28, 2024

Description

Adds the config file and dependency necessary to start tracking telemetry data via IBM Telemetry for the packages:

  • @carbon/cli
  • @carbon/colors
  • @carbon/elements
  • @carbon/feature-flags
  • @carbon/grid
  • @carbon/icon-helpers
  • @carbon/icons
  • @carbon/icons-react
  • @carbon/icons-vue
  • @carbon/layout
  • @carbon/motion
  • @carbon/pictograms
  • @carbon/pictograms-react
  • @carbon/styles
  • @carbon/themes
  • @carbon/type
  • @carbon/upgrade

The jsx config for the two -react packages were generated by running the JS config generator in the icon build helper package.

NOTE: This separate PR needs reviewed on the v10 branch with a new release after the PR is merged: #15852

Changelog

For each package listed above:

New

  • Adds @ibm/telemetry-js dependency
  • Adds telemetry.yml config file
  • Adds readme telemetry notice
  • Adds postinstall script to use the telemetry command
  • Adds telemetry.yml as an exported file if the package specifies files

Changed

  • N/A

Removed

  • @carbon/telemetry in @carbon/icons-react and @carbon/pictograms-react

Testing / Reviewing

Please look through package.json config files and ensure all necessary modifications have been made so that the "telemetry.yml" config file is included in the release version of each package.

PLEASE NOTE: In order for IBM Telemetry to start collecting data for this project, a new build must be published including these changes.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 54d5c48
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e0e21af76bdb0008f65182
😎 Deploy Preview https://deploy-preview-15844--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mattrosno mattrosno changed the title chore: onboard elements packages to IBM Telemetry 🚀 chore: onboard remaining packages to IBM Telemetry 🚀 Feb 28, 2024
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀🚀🚀🚀🚀

@mattrosno mattrosno added this pull request to the merge queue Mar 4, 2024
Merged via the queue into carbon-design-system:main with commit 9d4fbcd Mar 4, 2024
20 checks passed
@mattrosno mattrosno deleted the onboard-elements-telemetry branch March 4, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants