-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: active states and focus states of inline and standalone links #15846
fix: active states and focus states of inline and standalone links #15846
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Riddhi! Just one thing:
Focus state
In Firefox and Safari I can not get the Focus state on the actual Link in the example/demo on any of the stories. I could get it in Chrome, and it looks good! Just was wondering if that is a bug or if you have to operate things differently in those browsers to get the Focus on the link.
Seems like it is a problem on Safari and FF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurenmrice Its working on Safari as well , some settings needs to be changed. |
17b30f7
Closes #15613
Added an underline on the focus state and active state
Changed
Testing / Reviewing