Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multiselect): new All option for multiselect #16236

Merged
merged 62 commits into from
Aug 30, 2024
Merged

feat(multiselect): new All option for multiselect #16236

merged 62 commits into from
Aug 30, 2024

Conversation

Gururajj77
Copy link
Contributor

@Gururajj77 Gururajj77 commented Apr 22, 2024 •
edited
Loading

Closes #16117

Select All feature for multiselect

Changelog

New

  • All option created

Changed

  • changes in the logic for multiselect and selection.js

@Gururajj77 Gururajj77 changed the title Multiselect feat feat(multiselect): new All option for multiselect Apr 22, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c9536a7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66d2214ea9f03700083d7a65
😎 Deploy Preview https://deploy-preview-16236--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77 Gururajj77 marked this pull request as ready for review April 25, 2024 09:19
@Gururajj77 Gururajj77 requested a review from a team as a code owner April 25, 2024 09:19
guidari
guidari requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gururajj77 and @preetibansalui
Awesome new functionality! it is working perfect 🚀
Just a couple things I noticed

packages/react/src/components/MultiSelect/MultiSelect.tsx Outdated Show resolved Hide resolved
packages/react/src/components/MultiSelect/MultiSelect.tsx Outdated Show resolved Hide resolved
packages/react/src/components/ListBox/ListBoxMenuItem.tsx Outdated Show resolved Hide resolved
packages/react/src/components/ListBox/ListBoxMenuItem.tsx Outdated Show resolved Hide resolved
@Gururajj77 Gururajj77 requested a review from a team as a code owner May 3, 2024 10:20
@Gururajj77 @kennylam
Update packages/styles/scss/components/multiselect/_multiselect.scss
af158c5 
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
@laurenmrice
Copy link
Member

@Gururajj77 Is this ready to re-reviewed?

@Gururajj77
Copy link
Contributor Author

@Gururajj77 Is this ready to re-reviewed?

Yes, it's ready @laurenmrice

benjamin-kurien
benjamin-kurien requested changes Aug 14, 2024
View reviewed changes
Copy link

@benjamin-kurien benjamin-kurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selected items in the dropdown, needs to move up to the top of the list when dropdown is reopened. This functionality seems to missing. Please check.

benjamin-kurien
benjamin-kurien reviewed Aug 27, 2024
View reviewed changes
Copy link

@benjamin-kurien benjamin-kurien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a functional perspective. From a formatting perspective, the following alignments could get minor fixes:

  1. Vertical alignment for the checkbox with the text
  2. Vertical alignment for indeterminate icon within the checkbox

Thank you for your work on this.

@preetibansalui
Copy link
Contributor

This looks good from a functional perspective. From a formatting perspective, the following alignments could get minor fixes:

  1. Vertical alignment for the checkbox with the text
  2. Vertical alignment for indeterminate icon within the checkbox

Thank you for your work on this.

Hi Benjamin, I have fixed the alignment issue, Can you please review the changes again. Thanks!

benjamin-kurien
benjamin-kurien approved these changes Aug 27, 2024
View reviewed changes
Copy link

@benjamin-kurien benjamin-kurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. All alignment issues seems fixed. No functional issues either. Thank you.

tay1orjones
tay1orjones requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! The removals in the tests create some gaps in the test coverage. We should be able to find equivalents for those to keep the same coverage while no longer relying on data-contained-checkbox-state

packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js Outdated Show resolved Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js Outdated Show resolved Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js Outdated Show resolved Hide resolved
tay1orjones
tay1orjones approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a fix for the tests, LGTM!

@tay1orjones tay1orjones added this pull request to the merge queue Aug 30, 2024
Merged via the queue into carbon-design-system:main with commit 20c5abc Aug 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam left review comments

@preetibansalui preetibansalui preetibansalui left review comments

@tay1orjones tay1orjones tay1orjones approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@guidari guidari guidari approved these changes

@benjamin-kurien benjamin-kurien benjamin-kurien approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees

@Gururajj77 Gururajj77

@preetibansalui preetibansalui

Labels
status: ready to merge 🎉
Projects
Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiSelect (select all option): dev implementation
8 participants
@Gururajj77 @laurenmrice @preetibansalui @tay1orjones @kennylam @guidari @benjamin-kurien @riddhybansal