feat: allow grid offset and start reset #16479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Aug 6, 2024
|
LGTM, once there's two approvals we should remove the test stories before merging |
guidari
approved these changes
Aug 6, 2024
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Sep 3, 2024
3fcf739
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column offset cannot currently be reset for larger breakpoints.
When using the
<Colunn>component with an offset and a breakpoint it impacts on larger sizes. This PR allows thegrid-column-startto be reset.Added examples to the Storybook. Without the change the second column in
grid-start-end-some-breakpointsandgrid-offset-some-breakpointswraps on to the second row at large sizes.With the change it is not
Changelog
Changed
Testing / Reviewing
Reviewed in storybook