Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed types in FilterableMultiSelect #16702

Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jun 5, 2024

Closes #16491

Fixed types with wrong validation.

Changelog

New

  • Added the types in one file to share between MultiSelect and FilterableMultiSelect

Changed

  • Change name from Item to ItemType to match the type in MultiSelect

Testing / Reviewing

  • Make sure the MultiSelect and FilterableMultiSelect are working as expected
  • Make sure types make sense.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7ee4da1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66729ef86fe4320008d7a702
😎 Deploy Preview https://deploy-preview-16702--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7ee4da1
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66729ef8fded3200080a7fc8
😎 Deploy Preview https://deploy-preview-16702--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari added this pull request to the merge queue Jun 20, 2024
Merged via the queue into carbon-design-system:main with commit 5a2a702 Jun 20, 2024
22 checks passed
@guidari guidari deleted the 16491-filterablemultiselect branch June 20, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect typings for Filterable Multi Select
3 participants