Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UIShell): pass-through props on <HeaderContainer /> #16805

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

lluisrojass
Copy link
Contributor

@lluisrojass lluisrojass commented Jun 17, 2024

Closes #15975

Changelog

New

  • Changes documentation on the render propType
  • Adds a regression test

Changed

  • Allowing pass-through props on <HeaderContainer />'s render

Testing / Reviewing

  • TS Users can verify component and functional usage of<HeaderContainer /> render type checks as expected.

@lluisrojass lluisrojass requested a review from a team as a code owner June 17, 2024 17:21
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bceaf10
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667070a69c01e20008f72715
😎 Deploy Preview https://deploy-preview-16805--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bceaf10
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667070a674466900080257e7
😎 Deploy Preview https://deploy-preview-16805--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph added this pull request to the merge queue Jun 24, 2024
Merged via the queue into carbon-design-system:main with commit 412ce20 Jun 24, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants