Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): use contextual layer tokens #16860

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

janhassel
Copy link
Member

Closes #16859

Changelog

Changed

  • Updated modal wrapper elements from div to Layer

Removed

  • Component-specific style overwrites in modal.scss

Testing / Reviewing

  • Storybook
  • VRT

@janhassel janhassel requested a review from a team as a code owner June 25, 2024 06:53
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 612f501
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667a69612887ae0008d6358c
😎 Deploy Preview https://deploy-preview-16860--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 612f501
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667a69613a910a0008dc38dc
😎 Deploy Preview https://deploy-preview-16860--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b0a1625
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667a766e359bd600081c50ee
😎 Deploy Preview https://deploy-preview-16860--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b0a1625
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667a766e982c9e0008731ded
😎 Deploy Preview https://deploy-preview-16860--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Feels good to remove all those overrides.

@tay1orjones tay1orjones added this pull request to the merge queue Jun 25, 2024
Merged via the queue into carbon-design-system:main with commit db0978e Jun 25, 2024
22 checks passed
@janhassel janhassel deleted the modal-layer branch June 26, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Modal styles overwrite layering system
3 participants