fix(search): a11y warning on search not expanded #16873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
requested changes
Jun 26, 2024
riddhybansal
added
status: one more review 👀
and removed
status: ready for review 👀
status: failing CI 🙅♂️
labels
tay1orjones
approved these changes
Jun 28, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
alisonjoseph
approved these changes
Jul 1, 2024
guidari
approved these changes
Jul 1, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jul 1, 2024
5c37cc7
22 checks passed
|
Hey there! v11.61.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes carbon-design-system/ibm-products#4766
IBM Equal Access Accessibility Checker - warning on the search icon with
role="button"since it's not tabbableChangelog
Changed
aria-labelandrolefor the search icon to only have values whenonExpandTesting / Reviewing
Ran the IBM Equal Access Accessibility checker on the component
Before:
After:
