Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): ellipsis should only be applied with vertical variant #17004

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Jul 19, 2024

Closes #16999

FF displaying odd styles and sometimes accidentally applying a tooltip when not applicable

Changed

  • added an additional if statement when checking if Ellipsis should be applied by seeing if parent element is using vertical tabs

Testing / Reviewing

tested in storybook

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f2cab6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/669a97cacc9d6600089cd73d
😎 Deploy Preview https://deploy-preview-17004--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0f2cab6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/669a97ca68b5d900086e283b
😎 Deploy Preview https://deploy-preview-17004--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review July 19, 2024 16:58
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner July 19, 2024 16:58
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guidari guidari added this pull request to the merge queue Jul 19, 2024
Merged via the queue into carbon-design-system:main with commit 6c4a25e Jul 19, 2024
22 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/tab-ellipsis branch July 19, 2024 20:06
@2nikhiltom 2nikhiltom mentioned this pull request Jul 22, 2024
@tay1orjones tay1orjones mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tab styles not applied correctly in Firefox
3 participants