Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Test" stories from components. #17039

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jul 24, 2024

Removed "Test" stories from components.

Also, it is a good pratice to name our "Test" stories always as "Test", so it is easier to catch when we search in the storybook if we forget to remove before merging a PR.

@guidari guidari requested a review from a team as a code owner July 24, 2024 19:46
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning these up!

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8d672e0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66a1e2c922983d0008b0468f
😎 Deploy Preview https://deploy-preview-17039--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8d672e0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66a1e2c9921c7f00088e03e9
😎 Deploy Preview https://deploy-preview-17039--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riddhybansal riddhybansal added this pull request to the merge queue Jul 25, 2024
Merged via the queue into carbon-design-system:main with commit 7b24a10 Jul 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants