-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fileuploaderitem): use refs for ellipsis, add fowardRef to Text
#17104
fix(fileuploaderitem): use refs for ellipsis, add fowardRef to Text
#17104
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! maybe need to update title/commit message for merge if there's a CI check for that
Text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on Andrew's comment, commits/titles not in the proper format will not be picked up by the changelog script and won't be included in the changelog
5e4632c
Closes #16844
Changelog
New
forwardRef
to Text component.Changed
document.querySelector
touseRef
inFileUploaderItem
Testing / Reviewing
FileUploaderItem
. You can check the Drag and Drop examples in storybook.