Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileuploaderitem): use refs for ellipsis, add fowardRef to Text #17104

Merged
merged 9 commits into from
Aug 21, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Aug 5, 2024

Closes #16844

Changelog

New

  • Added forwardRef to Text component.

Changed

  • Convert the document.querySelector to useRef in FileUploaderItem

Testing / Reviewing

  • Check if there is no regressions in FileUploaderItem. You can check the Drag and Drop examples in storybook.

@guidari guidari requested a review from a team as a code owner August 5, 2024 12:00
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c2ebca7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66b649513903ee000814a9e2
😎 Deploy Preview https://deploy-preview-17104--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c2ebca7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66b6495154389f0008170a35
😎 Deploy Preview https://deploy-preview-17104--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari requested a review from a team as a code owner August 5, 2024 12:31
Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! maybe need to update title/commit message for merge if there's a CI check for that

@tay1orjones tay1orjones changed the title FileUploaderItem ellipses fix(fileuploaderitem): use refs for ellipsis, add fowardRef to Text Aug 21, 2024
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on Andrew's comment, commits/titles not in the proper format will not be picked up by the changelog script and won't be included in the changelog

@guidari guidari added this pull request to the merge queue Aug 21, 2024
Merged via the queue into carbon-design-system:main with commit 5e4632c Aug 21, 2024
22 checks passed
@guidari guidari deleted the 16844-fileuploader branch August 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FileUploaderItem not working in ShadowDOM
4 participants