Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): updated and new model icons #17169

Merged
merged 12 commits into from
Aug 22, 2024

Conversation

conradennis
Copy link
Contributor

@conradennis conradennis commented Aug 14, 2024

Submitting new and updated model UI icons as requested by @mjabbink here. All updates and additions approved by BXD

2 net new icons
4 updated icons
1 deprecated icon

updated categories.yml with additions
updated icons.yml with additions
updated deprecated.yml with additions

Changelog

New

  • 32/ml-model--reference.svg
  • 32/model--foundation.svg

Changed

  • 32/model.svg
  • 32/model--reference.svg
  • 32/model--tuned.svg
  • 32/machine-learning-model.svg

Deprecated

  • 32/machine-learning.svg

Submitting new and updated "model" UI icons as requested by @mjabbink all updates and additions approved by BXD

2 net new icons
4 updated icons
1 deprecated icon

updated categories.yml with additions
updated icons.yml with additions
updated deprecated.yml with additions
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me  ⭐️

@kennylam kennylam requested a review from a team as a code owner August 20, 2024 13:48
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dc55487
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c49ecd9a26390008afa709
😎 Deploy Preview https://deploy-preview-17169--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit dc55487
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c49ecd9c2581000862db16
😎 Deploy Preview https://deploy-preview-17169--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e88cb7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c7534e308bd9000835dafa
😎 Deploy Preview https://deploy-preview-17169--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6e88cb7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c7534e6cbdbb0008ad117d
😎 Deploy Preview https://deploy-preview-17169--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kennylam kennylam removed the request for review from tay1orjones August 20, 2024 14:59
@kennylam kennylam added this pull request to the merge queue Aug 22, 2024
Merged via the queue into carbon-design-system:main with commit 080b51c Aug 22, 2024
20 of 22 checks passed
@mjabbink
Copy link

mjabbink commented Sep 12, 2024

@conradennis @laurenmrice @tay1orjones It looks like foundation--model icon is not appearing in the Carbon UI icon library but I see it in the preview. Also, the icon library is not in synch wit the Carbon one.

Screenshot 2024-09-12 at 4 28 58 PM

@mjabbink
Copy link

Several M2W3 product teams are using these right now and missing now. Can you all look into this and resolve as soon as you can. Much thanks

@mjabbink
Copy link

and model is missing

image

@mjabbink
Copy link

oh, I see it in the site library, but it’s missing in the deploy preview. Seems to be in there so scratch the above entry on missing model icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants