feat(ai-label): add ts types #17295

ariellalgilmore · 2024-08-28T15:21:00Z

Closes #17232

Add typescript types to AI-label

Changelog

Changed

Converted AILabel file from JS to TSX.
updated align to copy Popover syntax with deprecated values

Testing / Reviewing

functionality stay the same
checks still passing
storybook looks good

ariellalgilmore · 2024-08-28T15:22:04Z

When checking the blame history in github you can still see the history even though it shows it as a new file

netlify · 2024-08-28T15:25:57Z

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`d296b91`
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-react/deploys/66cf405fece17c0008affa2f
😎 Deploy Preview	https://deploy-preview-17295--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-08-28T15:26:29Z

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	`d296b91`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/66cf405f45dc3800083468e5
😎 Deploy Preview	https://deploy-preview-17295--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-08-28T15:30:44Z

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`43d3070`
🔍 Latest deploy log	https://app.netlify.com/sites/v11-carbon-react/deploys/66e1ba2b0fd73a00086be07e
😎 Deploy Preview	https://deploy-preview-17295--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-08-28T15:32:18Z

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	`43d3070`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/66e1ba2bd88c0c0008008527
😎 Deploy Preview	https://deploy-preview-17295--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emyarod

looks good to me!

2nikhiltom

LGTM 💯

tay1orjones · 2024-09-10T16:51:44Z

packages/react/src/components/AILabel/index.tsx

+const propMappingFunction = (deprecatedValue) => {
+  const mapping = {
+    'top-left': 'top-start',
+    'top-right': 'top-end',
+    'bottom-left': 'bottom-start',
+    'bottom-right': 'bottom-end',
+    'left-bottom': 'left-end',
+    'left-top': 'left-start',
+    'right-bottom': 'right-end',
+    'right-top': 'right-start',
+  };
+  return mapping[deprecatedValue];
+};


Not a blocker to merge at all, but at some point we should probably make this a reusable helper - we're going to be using this all over the codebase 😅

I totally forgot we have one already:

carbon/packages/react/src/tools/createPropAdapter.js

Lines 44 to 67 in afce28d

export function mapPopoverAlignProp(align) {

switch (align) {

case 'top-left':

return 'top-start';

case 'top-right':

return 'top-end';

case 'bottom-left':

return 'bottom-start';

case 'bottom-right':

return 'bottom-end';

case 'left-bottom':

return 'left-end';

case 'left-top':

return 'left-start';

case 'right-bottom':

return 'right-end';

case 'right-top':

return 'right-start';

default:

return align;

}

}

export { mapDownshiftProps };

ooh thanks! I updated AI label!

codecov · 2024-09-11T15:37:57Z

Codecov Report

Attention: Patch coverage is 72.91667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (28032c3) to head (43d3070).

Files with missing lines	Patch %	Lines
packages/react/src/components/AILabel/index.tsx	72.91%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17295      +/-   ##
==========================================
- Coverage   76.83%   76.83%   -0.01%     
==========================================
  Files         408      408              
  Lines       13945    13949       +4     
  Branches     4323     4276      -47     
==========================================
+ Hits        10715    10718       +3     
- Misses       3056     3058       +2     
+ Partials      174      173       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

carbon-automation · 2024-09-13T16:20:40Z

Hey there! v11.66.0 was just released that references this issue/PR.

ariellalgilmore added 3 commits August 28, 2024 08:15

fix(ai-label): new tsx extension

cbe31be

fix(ai-label): add types

e46a307

fix(snapshots): update

d296b91

ariellalgilmore mentioned this pull request Aug 28, 2024

feat(ai-label): add typescript types #17261

Closed

Merge branch 'main' into fix/ai-label-test-branch

aea3c2c

ariellalgilmore marked this pull request as ready for review August 28, 2024 15:26

ariellalgilmore requested review from a team as code owners August 28, 2024 15:26

ariellalgilmore requested review from tay1orjones and emyarod August 28, 2024 15:26

emyarod approved these changes Aug 29, 2024

View reviewed changes

Merge branch 'main' into fix/ai-label-test-branch

8fe15a1

2nikhiltom approved these changes Sep 4, 2024

View reviewed changes

Merge branch 'main' into fix/ai-label-test-branch

abba443

ariellalgilmore enabled auto-merge September 9, 2024 19:15

ariellalgilmore added 2 commits September 10, 2024 07:20

Merge branch 'main' into fix/ai-label-test-branch

2981c43

Merge branch 'main' into fix/ai-label-test-branch

d864090

annawen1 approved these changes Sep 10, 2024

View reviewed changes

Merge branch 'main' into fix/ai-label-test-branch

12273ca

tay1orjones approved these changes Sep 10, 2024

View reviewed changes

ariellalgilmore added this pull request to the merge queue Sep 10, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 10, 2024

ariellalgilmore added 3 commits September 10, 2024 10:48

fix(prop-mapping): use mapPopoverAlignProp

affb7fc

fix(popover): restructure

d84293c

fix(popover): leave as is

1886b65

ariellalgilmore enabled auto-merge September 11, 2024 15:26

Merge branch 'main' into fix/ai-label-test-branch

43d3070

ariellalgilmore added this pull request to the merge queue Sep 11, 2024

Merged via the queue into carbon-design-system:main with commit cfba956 Sep 11, 2024
23 checks passed

ariellalgilmore deleted the fix/ai-label-test-branch branch September 11, 2024 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ai-label): add ts types #17295

feat(ai-label): add ts types #17295

ariellalgilmore commented Aug 28, 2024

ariellalgilmore commented Aug 28, 2024

netlify bot commented Aug 28, 2024

netlify bot commented Aug 28, 2024

netlify bot commented Aug 28, 2024 •

edited

Loading

netlify bot commented Aug 28, 2024 •

edited

Loading

emyarod left a comment

2nikhiltom left a comment

tay1orjones Sep 10, 2024

tay1orjones Sep 10, 2024

ariellalgilmore Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading

carbon-automation bot commented Sep 13, 2024

	export function mapPopoverAlignProp(align) {
	switch (align) {
	case 'top-left':
	return 'top-start';
	case 'top-right':
	return 'top-end';
	case 'bottom-left':
	return 'bottom-start';
	case 'bottom-right':
	return 'bottom-end';
	case 'left-bottom':
	return 'left-end';
	case 'left-top':
	return 'left-start';
	case 'right-bottom':
	return 'right-end';
	case 'right-top':
	return 'right-start';
	default:
	return align;
	}
	}

	export { mapDownshiftProps };

feat(ai-label): add ts types #17295

feat(ai-label): add ts types #17295

Conversation

ariellalgilmore commented Aug 28, 2024

Changelog

Testing / Reviewing

ariellalgilmore commented Aug 28, 2024

netlify bot commented Aug 28, 2024

✅ Deploy Preview for v11-carbon-react ready!

netlify bot commented Aug 28, 2024

✅ Deploy Preview for carbon-elements ready!

netlify bot commented Aug 28, 2024 • edited Loading

✅ Deploy Preview for v11-carbon-react ready!

netlify bot commented Aug 28, 2024 • edited Loading

✅ Deploy Preview for carbon-elements ready!

emyarod left a comment

Choose a reason for hiding this comment

2nikhiltom left a comment

Choose a reason for hiding this comment

tay1orjones Sep 10, 2024

Choose a reason for hiding this comment

tay1orjones Sep 10, 2024

Choose a reason for hiding this comment

ariellalgilmore Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Sep 11, 2024 • edited Loading

Codecov Report

carbon-automation bot commented Sep 13, 2024

netlify bot commented Aug 28, 2024 •

edited

Loading

netlify bot commented Aug 28, 2024 •

edited

Loading

ariellalgilmore Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading