Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed highlight token color #17430

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 12, 2024

Closes #17371

Fixed g90 and g100 themes.

I tested locally the token and now it is returning the correct color.

Testing / Reviewing

  • When using the highlight token it should show the correct colors

carbon-automation bot and others added 2 commits September 12, 2024 09:47
Co-authored-by: tay1orjones <3360588+tay1orjones@users.noreply.github.com>
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
@guidari guidari requested a review from a team as a code owner September 12, 2024 17:50
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4e0d709
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e329f3e4a8a10007e7eaa4
😎 Deploy Preview https://deploy-preview-17430--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e0d709
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e329f35d27fb0008a3884b
😎 Deploy Preview https://deploy-preview-17430--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kennylam kennylam added this pull request to the merge queue Sep 13, 2024
Merged via the queue into carbon-design-system:main with commit 98ca47c Sep 13, 2024
23 checks passed
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (a6f1b23) to head (4e0d709).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17430      +/-   ##
==========================================
- Coverage   76.82%   76.82%   -0.01%     
==========================================
  Files         408      408              
  Lines       13966    13973       +7     
  Branches     4336     4337       +1     
==========================================
+ Hits        10730    10735       +5     
- Misses       3062     3065       +3     
+ Partials      174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carbon-automation
Copy link
Contributor

Hey there! v11.66.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$highlight token values are incorrect in g90 and g100 themes
3 participants