Fixed ActionableNotification with closeOnEscape prop
#17433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tay1orjones <3360588+tay1orjones@users.noreply.github.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17433 +/- ##
==========================================
- Coverage 76.87% 76.85% -0.02%
==========================================
Files 408 408
Lines 13974 13975 +1
Branches 4340 4337 -3
==========================================
- Hits 10742 10740 -2
- Misses 3058 3061 +3
Partials 174 174 ☔ View full report in Codecov by Sentry. |
Merged
via the queue into
carbon-design-system:main
with commit Sep 14, 2024
06844e9
36 checks passed
guidari
added a commit
to guidari/carbon
that referenced
this pull request
Sep 18, 2024
…gn-system#17433) * chore(release): v11.66.0 (carbon-design-system#17413) Co-authored-by: tay1orjones <3360588+tay1orjones@users.noreply.github.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> * fix: fixed onKeyDown --------- Co-authored-by: carbon-automation[bot] <103539138+carbon-automation[bot]@users.noreply.github.com> Co-authored-by: tay1orjones <3360588+tay1orjones@users.noreply.github.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16153
The
addEventListenerkeydown was being created even after removed. So now we are checking if theref.currentcontains a value or it is null.Testing / Reviewing