Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to Tag Skeleton #17460

Merged
merged 11 commits into from
Sep 19, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 17, 2024

Closes #17438

Added testing to Tag Skeleton

Changelog

Testing / Reviewing

  • Test coverage should increase

@guidari guidari requested a review from a team as a code owner September 17, 2024 14:38
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b3300dc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66ebafff88866400082d2ad4
😎 Deploy Preview https://deploy-preview-17460--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b3300dc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66ebafff450b730008419787
😎 Deploy Preview https://deploy-preview-17460--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.95%. Comparing base (494e28c) to head (b3300dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17460      +/-   ##
==========================================
+ Coverage   76.92%   76.95%   +0.02%     
==========================================
  Files         408      408              
  Lines       13979    13979              
  Branches     4291     4291              
==========================================
+ Hits        10754    10758       +4     
+ Misses       3052     3048       -4     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@2nikhiltom 2nikhiltom added this pull request to the merge queue Sep 19, 2024
Merged via the queue into carbon-design-system:main with commit fab91fa Sep 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test coverage for Tag.Skeleton
4 participants