fix(Notification): add NPE check in escape close handler #17528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
16874-fix/notification-tab-error-on-close
branch
from
73027d9
to
6af2c70
Compare
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17528 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 408 408
Lines 13979 13979
Branches 4343 4343
=======================================
Hits 10758 10758
Misses 3047 3047
Partials 174 174 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Sep 19, 2024
ariellalgilmore
approved these changes
Sep 20, 2024
ariellalgilmore
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Sep 21, 2024
e4fe031
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16874
This PR adds a NPE check to the Notification Esc key handler to prevent console errors after dismissal
Changelog
Changed
useEscapeToClosehandlerTesting / Reviewing