test(e2e): add PublicAPI tests and use metadata for icon tests #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
…test/add-exports-test-for-icons
|
Deploy preview for carbon-elements ready! Built with commit c7b0603 |
|
Deploy preview for carbon-components-react ready! Built with commit c7b0603 https://deploy-preview-5846--carbon-components-react.netlify.com |
joshblack
commented
Apr 10, 2020
| if (Array.isArray(icon.namespace) && icon.namespace.length > 0) { | ||
| entry.namespace = icon.namespace.join('/'); | ||
| } | ||
| entry.namespace = Array.isArray(icon.namespace) ? icon.namespace : []; |
There was a problem hiding this comment.
Just a quick heads up for metadata changes @vpicone just going to have this be an array instead of converting it 👍
|
Deploy preview for carbon-elements ready! Built with commit ec9cc37 |
|
Deploy preview for carbon-components-react ready! Built with commit e44d813 https://deploy-preview-5846--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit ec9cc37 https://deploy-preview-5846--carbon-components-react.netlify.com |
aledavila
approved these changes
Apr 14, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Apr 16, 2020
…n-design-system#5846) * chore(github): update CODEOWNERS syntax for PublicAPI files * test(e2e): add PublicAPI tests and use metadata for icon tests * fix(icons): add registry to exports and check for duplicate sizes * test(matchers): defer AAT module resolution until called * docs(icon-build-helpers): add jsdoc for load export * test(e2e): add ESM files to exports test * chore(test): update paths for registry * chore(github): update CODEOWNERS comments * fix(icon-build-helpers): set namespace for pictograms * fix(pictograms): add main and module fields to package.json * test(e2e): add e2e tests for pictograms and pictograms-react Co-authored-by: TJ Egan <tw15egan@gmail.com>
joshblack
added a commit
that referenced
this pull request
Apr 21, 2020
* chore(github): update CODEOWNERS syntax for PublicAPI files * test(e2e): add PublicAPI tests and use metadata for icon tests * fix(icons): add registry to exports and check for duplicate sizes * test(matchers): defer AAT module resolution until called * docs(icon-build-helpers): add jsdoc for load export * test(e2e): add ESM files to exports test * chore(test): update paths for registry * chore(github): update CODEOWNERS comments * fix(icon-build-helpers): set namespace for pictograms * fix(pictograms): add main and module fields to package.json * test(e2e): add e2e tests for pictograms and pictograms-react Co-authored-by: TJ Egan <tw15egan@gmail.com>
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds updated e2e tests for icons and icons-react, including a Public API snapshot and tests that leverage metadata as a source of truth.
Changelog
New
loadhelper toMetadatato load metadata information in-memory instead of persisting to diske2e/iconsande2e/icons-react. These test the public exports of these packagesChanged
Removed