-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): change thead to sticky position with z-index #5887
Conversation
This change makes `thead` stick to the top of the table container and ensures the elements in `thead` are visible as the table body is scrolled.
Deploy preview for carbon-elements ready! Built with commit aec5231 |
Deploy preview for carbon-components-react ready! Built with commit aec5231 https://deploy-preview-5887--carbon-components-react.netlify.app |
Getting a lot of top padding when enabling sticky header Also, as a heads up, doesn't seem like |
@tw15egan Fixed the padding issue. Carbon still supports IE11 😱 ? I don't think Microsoft even supports IE11 anymore. Carbon should consider just supporting evergreen browsers. |
@virkt25 at the moment we're still supporting IE11, but hopefully for not too much longer 😅 It doesn't look like the old sticky header functionality worked in IE11 anyways, so since it's an experimental feature I'm fine with keeping it like this 👍 |
…gn-system#5887) * fix(table): change thead to sticky position with z-index This change makes `thead` stick to the top of the table container and ensures the elements in `thead` are visible as the table body is scrolled. * fix(data-table): remove padding as we switch to sticky position Co-authored-by: TJ Egan <tw15egan@gmail.com>
…gn-system#5887) * fix(table): change thead to sticky position with z-index This change makes `thead` stick to the top of the table container and ensures the elements in `thead` are visible as the table body is scrolled. * fix(data-table): remove padding as we switch to sticky position Co-authored-by: TJ Egan <tw15egan@gmail.com>
* fix(table): change thead to sticky position with z-index This change makes `thead` stick to the top of the table container and ensures the elements in `thead` are visible as the table body is scrolled. * fix(data-table): remove padding as we switch to sticky position Co-authored-by: TJ Egan <tw15egan@gmail.com>
This change makes
thead
stick to the top of the table container and ensures the elements inthead
are visible as the table body is scrolled. Also allows for horizontal scrolling while honouring the sticky header.Changelog
Changed
thead
now usesposition: sticky
instead ofposition: fixed
thead
has a z-index of 1Testing / Reviewing