fix(ui-shell): fix padding when fixed side nav is using icons #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 85c0667 |
|
Deploy preview for carbon-components-react ready! Built with commit 85c0667 https://deploy-preview-5896--carbon-components-react.netlify.app |
joshblack
approved these changes
Apr 20, 2020
asudoh
requested review from
a team and
laurenmrice
and removed request for
a team
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 23, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Apr 23, 2020
joshblack
pushed a commit
that referenced
this pull request
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5889
Adds more specificity to selector so that padding is not decreased when icons are present
Changelog
Changed
Testing / Reviewing
Go to
Fixed Sidenav w/ Iconsstory, addclassName="bx--side-nav--fixed"to the SideNav component, then view the story and make sure the sub-menu items have 72px of left padding