Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devenv): remove forced viewport height #603

Merged
merged 1 commit into from
Feb 22, 2018
Merged

chore(devenv): remove forced viewport height #603

merged 1 commit into from
Feb 22, 2018

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Feb 22, 2018

Overview

Resolves 1. in #579 (comment)

Removed

The forced viewport height in dev env.

Testing / Reviewing

Testing should make sure the dev env is not broken.

@asudoh asudoh mentioned this pull request Feb 22, 2018
Merged
3 tasks
marijohannessen
marijohannessen approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@marijohannessen marijohannessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

@marijohannessen marijohannessen merged commit 7a9b8b6 into carbon-design-system:master Feb 22, 2018
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
refactor(Modal): update classes for 3.x branch (carbon-design-system#603
4ee2e1c 
)

* chore(Modal): move aziz work to new PR

* fix(Modal): fix heading class

* test(Modal): update tests

* chore(a11y): lock down @ibm/aat@1.2.0

* test(a11y): fix test for Modal and ModalWrapper

* fix(ModalWrapper): close Modal on keyDown esc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marijohannessen marijohannessen marijohannessen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asudoh @marijohannessen