chore(slider): add no wrap white space to range label #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 6e21a60 |
|
Deploy preview for carbon-components-react ready! Built with commit 6e21a60 https://deploy-preview-6644--carbon-components-react.netlify.app |
|
@aledavila is there an issue or repro of the problem that this is solving? 👀 |
|
@joshblack So I had a question on slack about using labels but they had the issue with the spacing. And asked Anna about it. So the issue is that if you input a word it won't have the space since its meant for increments. So you'd have to manually add a space in your prop but if you do so it wraps. So I just made it so it wouldn't wrap.
|
andreancardona
approved these changes
Aug 10, 2020
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
joshblack
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a no wrap to the range labels in the rare event that a user needs to have a word instead of a unit increment. However, because it's meant for unit increments a user would need to manually add their own space before the label in the prop. This helps in that use case so the word doesn't wrap and stays on the same line.
Testing / Reviewing
Check that slider and labels look fine.