fix(DataTable): add absolute back to batch data #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolute positioning with right and left moving for items in Batch actions to match proper styling (as seen in all Carbon Design docs). This will not allow scrolling, but if we want scrolling it seems we should maybe alter the design on tablet and under instead of tossing everything to the left.
|
Critical for IBM Aspera who reported this broke styling in 10.17 of Carbon. |
|
Deploy preview for carbon-elements ready! Built with commit 7e4a28c |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 7e4a28c https://deploy-preview-6660--carbon-components-react.netlify.app |
tw15egan
approved these changes
Aug 13, 2020
joshblack
approved these changes
Aug 19, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6656
Absolute positioning with right and left moving for items in Batch actions to match proper styling (as seen in all Carbon Design docs).
This will not allow scrolling, but if we want scrolling it seems we should maybe alter the design on tablet and under instead of tossing everything to the left.
Changelog
Changed
This partially undoes 7fdbf46#diff-40653676b081d16cc9854adb4114608fL470
Testing / Reviewing