feat(Tabs): add support for Home and End key navigation #7155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
7070-tabs-home-end-key-support
branch
from
a8104a3
to
d5c26c0
Compare
|
Deploy preview for carbon-elements ready! Built with commit a8104a3 |
|
Deploy preview for carbon-components-react ready! Built with commit a8104a3 https://deploy-preview-7155--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit ca5648b |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit ca5648b https://deploy-preview-7155--carbon-components-react.netlify.app |
aledavila
approved these changes
Nov 2, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7070
This PR adds support for Home and End key navigation in the Tabs component
Changelog
New
Testing / Reviewing
Confirm the added keyboard controls function as expected