-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Search): add Esc button support to clear input field #7230
feat(Search): add Esc button support to clear input field #7230
Conversation
Deploy preview for carbon-elements ready! Built with commit 832c37f |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 832c37f https://deploy-preview-7230--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did we not have this? 🤕 Great job! Tested on Firefox on Windows 10
Closes #7228
This PR adds Esc button support to clear the Search component input field
Changelog
New
Changed
onChange
event handlers so that they are not overwritten by<Search />
s internal change event handlerTesting / Reviewing
Confirm the Esc key clears the search input field and any attached
onChange
oronKeyDown
handlers are still fired